Enable addition OAuth 2.0 grant flows #83
Conversation
blakeembrey
force-pushed
the
oauth2-grants
branch
3 times, most recently
from
63b4d40 to
4a56bd5
Compare
| var authorization = btoa(credentials.clientId + ':' + credentials.clientSecret); | ||
|
|
||
| return { | ||
| 'Authorization': 'Bearer' + authorization |
There was a problem hiding this comment.
Are we missing space after Bearer?
|
Any thoughts about failed build? Just a noise? |
|
The broken build is because of this: In angular 1.2.16, they fixed some bugs, which the api-console relies on for rendering the (+) button at the last item of a repeatable named parameter: https://github.com/mulesoft/api-console/blob/master/app/views/repeatable.tmpl.html#L6 After that patch, the transcluded items do not share the same scope as the transcluder, and the the $last scope variable is no longer present in the transcluded scope. To fix this we would need a semi-major overhaul o named parameters. |
|
|
||
| <div class="control-group" ng-if="credentials.grantType.type !== 'token'"> | ||
| <label for="clientSecret"> | ||
| <span class="required" ng-show="credentials.grantType.type !== 'owner'">*</span> |
There was a problem hiding this comment.
Would it be cleaner to do something like:
In CSS:
.required:after {
content: "*";
}and then
<label for="clientSecret" ng-style:"{required: requiresSecret}">and add to the controller:
$scope.requiresSecret = credentials.grantType.type !== 'token';and remove the span?
There was a problem hiding this comment.
Probably, I was just using what had already been implemented though.
There was a problem hiding this comment.
Then let me rephrase:
I think we should do something like:
In CSS:
.required:after {
content: "*";
}and then
<label for="clientSecret" ng-style:"{required: requiresSecret}">and add to the controller:
$scope.requiresSecret = credentials.grantType.type !== 'token';and remove the span.
There was a problem hiding this comment.
Ok, that change is now a part of this PR. It only changes one part of unrelated code.
blakeembrey
force-pushed
the
oauth2-grants
branch
3 times, most recently
from
05e7f37 to
4b59917
Compare
blakeembrey
force-pushed
the
oauth2-grants
branch
from
4b59917 to
a476695
Compare
|
LGTM |
|
@blakeembrey When you merge this one, can you also update the console version in api-designer and send me the SHAs, so I can update the tooling in our side? |
|
Don't forget to re-build console and designer. |
Enable addition OAuth 2.0 grant flows
No description provided.